Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline repo groups #34

Merged
merged 2 commits into from
Apr 27, 2023
Merged

baseline repo groups #34

merged 2 commits into from
Apr 27, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Feb 28, 2023

Description

Baseline repo maintainers and codeowners

Issues Resolved

Fix #31

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho requested a review from a team as a code owner February 28, 2023 17:03
@derek-ho
Copy link
Collaborator Author

derek-ho commented Mar 1, 2023

Not sure why CI is failing, can someone take a look?

@MaxKsyunz
Copy link
Collaborator

MaxKsyunz commented Mar 1, 2023

Created #37 to track the build failure.

Signed-off-by: Derek Ho <dxho@amazon.com>
@bbarani
Copy link
Member

bbarani commented Apr 25, 2023

You need to invite Max Ksyunz, Yury Fridlyand and add them as maintainers before merging this PR. CODEOWNERS file is not green now.

@derek-ho
Copy link
Collaborator Author

Added per the ticket, merging now

@derek-ho derek-ho merged commit 85678a0 into opensearch-project:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions
6 participants