Refactor AWSSigV4 auth to support different AWSCredentialProviders #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudha
previously approved these changes
Mar 3, 2023
kavithacm
previously approved these changes
Mar 3, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #1389 +/- ##
=========================================
Coverage 98.38% 98.38%
- Complexity 3698 3699 +1
=========================================
Files 345 345
Lines 9113 9119 +6
Branches 585 586 +1
=========================================
+ Hits 8966 8972 +6
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Comment on lines
67
to
69
| LOG.info(awsCredentialsProvider.getClass()); | ||
| LOG.info("Access Key: {}", awsCredentials.getAWSAccessKeyId()); | ||
| LOG.info("Secret Key: {}", awsCredentials.getAWSSecretKey()); |
There was a problem hiding this comment.
Are you sure that you want to log your passwords as plain text?
There was a problem hiding this comment.
Thanks for pointing out...I was splitting a big PR and left these lines.
vamsi-amazon
force-pushed
the
refactor-sigv4-auth
branch
2 times, most recently
from
a34ceec
to
a8dcece
Compare
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon
force-pushed
the
refactor-sigv4-auth
branch
from
a8dcece
to
93a82a8
Compare
vamsi-amazon
added
backport main
maintenance
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
rupal-bq
approved these changes
Mar 3, 2023
penghuo
approved these changes
Mar 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 3, 2023
…1389) * Refactor AWSSigV4 auth to support different AWSCredentialProviders Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Added unit tests for sts assume role credentials provider Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 8583fd1)
vamsi-amazon
added a commit
that referenced
this pull request
Mar 7, 2023
…1389) * Refactor AWSSigV4 auth to support different AWSCredentialProviders Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Added unit tests for sts assume role credentials provider Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 8583fd1)
vamsi-amazon
added a commit
that referenced
this pull request
Mar 7, 2023
…1389) (#1396) * Refactor AWSSigV4 auth to support different AWSCredentialProviders Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Added unit tests for sts assume role credentials provider Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 8583fd1) Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
matthewryanwells
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Mar 10, 2023
…pensearch-project#1389) (opensearch-project#1396) * Refactor AWSSigV4 auth to support different AWSCredentialProviders Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Added unit tests for sts assume role credentials provider Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 8583fd1) Co-authored-by: vamsi-amazon <reddyvam@amazon.com> Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored sigv4auth support to use credential Providers.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.