Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added COSH to V2 engine #1428

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

matthewryanwells
Copy link
Contributor

@matthewryanwells matthewryanwells commented Mar 13, 2023

Description

Added COSH to V2 engine, updated documentation, added unit/IT tests

Issues Resolved

#1190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@matthewryanwells matthewryanwells requested a review from a team as a code owner March 13, 2023 16:27
@codecov-commenter
Copy link

Codecov Report

Merging #1428 (2d0e1db) into main (ef38389) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #1428      +/-   ##
============================================
- Coverage     98.38%   98.38%   -0.01%     
  Complexity     3698     3698              
============================================
  Files           343      343              
  Lines          9121     9118       -3     
  Branches        586      582       -4     
============================================
- Hits           8974     8971       -3     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

acarbonetto
acarbonetto previously approved these changes Mar 14, 2023
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Mar 15, 2023
@dai-chen dai-chen merged commit 8dad71f into opensearch-project:main Mar 15, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1428-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8dad71f47accd2fa8c24579fe339e82909fdb751
# Push it to GitHub
git push --set-upstream origin backport/backport-1428-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1428-to-2.x.

@Yury-Fridlyand Yury-Fridlyand deleted the integ-cosh branch April 20, 2023 15:38
matthewryanwells added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 20, 2023
* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8dad71f)
dai-chen pushed a commit that referenced this pull request Apr 20, 2023
* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8dad71f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants