Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add EXTRACT Function To OpenSearch SQL Plugin #1443

Merged

Conversation

GabeFernandez310
Copy link
Contributor

Manually backport 87018c6 from #1421

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

)

* Add `EXTRACT` Function To OpenSearch SQL Plugin

* Added Basic Tests

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Added Lexer And Parser Language

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Added Implementation And Fixed Tests

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Added Documentation

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Modified Implementation And Tests

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Fixed Checkstyle Issues

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Added Javadoc comments and Tests

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Changed Implementation

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Changed A Test

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Fixed Integration Tests

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Refactored Extract Tests Into New File

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Refactored Tests

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Renamed Rule In Parser

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Fixed AstExpressionBuilder

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

---------

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Removed Unneeded Code And Added Parser Test

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

---------

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 87018c6)
@GabeFernandez310 GabeFernandez310 changed the title Add EXTRACT Function To OpenSearch SQL Plugin (#1421) [Backport 2.x] Add EXTRACT Function To OpenSearch SQL Plugin Mar 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #1443 (c6abda9) into 2.x (7122a55) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x    #1443   +/-   ##
=========================================
  Coverage     98.39%   98.40%           
- Complexity     3711     3719    +8     
=========================================
  Files           343      343           
  Lines          9152     9199   +47     
  Branches        582      582           
=========================================
+ Hits           9005     9052   +47     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...pensearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GabeFernandez310 GabeFernandez310 marked this pull request as ready for review March 16, 2023 16:33
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner March 16, 2023 16:33
@dai-chen dai-chen added the enhancement New feature or request label Mar 16, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit 29f005f into opensearch-project:2.x Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants