[Backport 2.x] Add STR_TO_DATE Function To The SQL Plugin
#1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `STR_TO_DATE` Function To The SQL Plugin. * Added Tests Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Added Empty Implementation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Added Partially Working Implementation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Cleaned Up Implementation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Modified Implementation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Modified IT Test Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Added Documentation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Added Unit Tests Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Altered Implementation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Reworked Implementation To Always Return Datetime Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Addressed PR Comments Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed Some Checkstyle Issues Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Cleaned Implementation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Supported Function Properties Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed Checkstyle Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Removed Unneeded Function Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Cleaned Implementation and Added IT Test Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed Code Coverage and Implementation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> --------- Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Cleaned Implementation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> --------- Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit 40336d4)
Yury-Fridlyand
approved these changes
Mar 16, 2023
dai-chen
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually backport 40336d4 from #1420
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.