Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Added Arithmetic functions to V2 engine #1448

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[Backport 2.x] Added Arithmetic functions to V2 engine #1448

merged 1 commit into from
Mar 17, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bc39346 from #1416

@matthewryanwells @github-actions
Added Arithmetic functions to V2 engine (#1416)
20800d7 
* Updated Arithmetic functions from old engine to new engine (#235)

* Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit bc39346)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 16, 2023 21:00
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023 •
edited

Codecov Report

Merging #1448 (20800d7) into 2.x (5f1747d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x    #1448   +/-   ##
=========================================
  Coverage     98.42%   98.42%           
- Complexity     3754     3757    +3     
=========================================
  Files           343      343           
  Lines          9312     9315    +3     
  Branches        597      597           
=========================================
+ Hits           9165     9168    +3     
  Misses          142      142           
  Partials          5        5
Flag Coverage Δ
sql-engine 98.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...ression/operator/arthmetic/ArithmeticFunction.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the enhancement New feature or request label Mar 17, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit c286846 into 2.x Mar 17, 2023
@github-actions github-actions bot deleted the backport/backport-1416-to-2.x branch March 17, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-chen dai-chen dai-chen approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codecov-commenter @dai-chen @Yury-Fridlyand @matthewryanwells