Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST API for GET,PUT and DELETE #1482

Merged
merged 2 commits into from
Apr 6, 2023
Merged

REST API for GET,PUT and DELETE #1482

merged 2 commits into from
Apr 6, 2023

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Mar 28, 2023 •
edited

Description

These changes introduce REST APIs for GET DATASOURCE, UPDATE DATASOURCE and DELETE DATASOURCE APIS as follow up to CREATE DATASOURCE APIs #1458

Issues Resolved

Rough LLD Diagrams

Modification of datasource is similar to create apis. Below images corresponds to GET ALL and DELETE APIs.

Screen Shot 2023-03-28 at 3 51 46 PM

Screen Shot 2023-03-28 at 3 51 33 PM

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vamsi-amazon vamsi-amazon self-assigned this Mar 28, 2023
This was linked to issues Mar 28, 2023
[FEATURE] Delete Datasource API #1460
Closed
[FEATURE]Get Datasource API #1461
Closed
[FEATURE]Update Datasource API #1462
Closed
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023 •
edited

Codecov Report

Merging #1482 (dcfbff2) into main (23cc0f6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1482   +/-   ##
=========================================
  Coverage     98.46%   98.47%           
- Complexity     3869     3886   +17     
=========================================
  Files           345      347    +2     
  Lines          9603     9649   +46     
  Branches        616      625    +9     
=========================================
+ Hits           9456     9502   +46     
  Misses          142      142           
  Partials          5        5
Flag Coverage Δ
sql-engine 98.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/sql/datasource/DataSourceLoaderCacheImpl.java 100.00% <100.00%> (ø)
...ensearch/sql/datasource/DataSourceServiceImpl.java 100.00% <100.00%> (ø)
...source/exceptions/DataSourceNotFoundException.java 100.00% <100.00%> (ø)
...anner/physical/datasource/DataSourceTableScan.java 100.00% <100.00%> (ø)
...l/prometheus/storage/PrometheusStorageFactory.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vamsi-amazon vamsi-amazon force-pushed the get-put-delete-main branch 3 times, most recently from 60669a2 to e8a7270 Compare March 29, 2023 20:28
@vamsi-amazon vamsi-amazon marked this pull request as ready for review March 29, 2023 20:29
dai-chen
dai-chen requested changes Mar 29, 2023
View reviewed changes
core/src/main/java/org/opensearch/sql/datasource/DataSourceService.java Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/datasource/DataSourceAPIsIT.java Outdated Show resolved Hide resolved
opensearch/src/main/java/org/opensearch/sql/opensearch/storage/OpenSearchDataSourceFactory.java Outdated Show resolved Hide resolved
plugin/src/main/java/org/opensearch/sql/plugin/rest/RestDataSourceQueryAction.java Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/datasource/DataSourceServiceImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/datasource/DataSourceServiceImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/datasource/DataSourceServiceImpl.java Outdated Show resolved Hide resolved
YANG-DB
YANG-DB previously approved these changes Mar 29, 2023
View reviewed changes
core/src/main/java/org/opensearch/sql/datasource/DataSourceServiceImpl.java Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/datasource/DataSourceServiceImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/datasource/DataSourceServiceImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/datasource/DataSourceServiceImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/storage/DataSourceFactory.java Outdated Show resolved Hide resolved
core/src/test/java/org/opensearch/sql/analysis/AnalyzerTestBase.java Outdated Show resolved Hide resolved
core/src/main/java/org/opensearch/sql/datasource/DataSourceService.java Outdated Show resolved Hide resolved
.../src/main/java/org/opensearch/sql/plugin/datasource/OpenSearchDataSourceMetadataStorage.java Show resolved Hide resolved
.../src/main/java/org/opensearch/sql/plugin/datasource/OpenSearchDataSourceMetadataStorage.java Show resolved Hide resolved
.../src/main/java/org/opensearch/sql/plugin/datasource/OpenSearchDataSourceMetadataStorage.java Show resolved Hide resolved
@vamsi-amazon vamsi-amazon force-pushed the get-put-delete-main branch 3 times, most recently from e73bab8 to 1dd1ee9 Compare March 29, 2023 23:03
@vamsi-amazon vamsi-amazon force-pushed the get-put-delete-main branch 2 times, most recently from 9e85e8b to 2069e97 Compare April 3, 2023 23:24
YANG-DB
YANG-DB previously approved these changes Apr 4, 2023
View reviewed changes
@vamsi-amazon vamsi-amazon force-pushed the get-put-delete-main branch 3 times, most recently from ed3c0a9 to 62a9820 Compare April 5, 2023 07:05
dai-chen
dai-chen previously approved these changes Apr 6, 2023
View reviewed changes
@vamsi-amazon
REST API for GET,PUT and DELETE
c4335af 
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
@vamsi-amazon vamsi-amazon dismissed stale reviews from dai-chen and penghuo via c4335af April 6, 2023 09:07
@vamsi-amazon
changed permission action names
dcfbff2 
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
@vamsi-amazon vamsi-amazon merged commit 3fbbaa4 into opensearch-project:main Apr 6, 2023
13 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2023
@vamsi-amazon @github-actions
REST API for GET,PUT and DELETE (#1482)
15d2aba 
* REST API for GET,PUT and DELETE

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* changed permission action names

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

---------

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit 3fbbaa4)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2023
@vamsi-amazon @github-actions
REST API for GET,PUT and DELETE (#1482)
8b04b9a 
* REST API for GET,PUT and DELETE

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* changed permission action names

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

---------

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit 3fbbaa4)
vamsi-amazon pushed a commit that referenced this pull request Apr 6, 2023
@opensearch-trigger-bot
REST API for GET,PUT and DELETE (#1482) (#1502)
a796433 
* REST API for GET,PUT and DELETE

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vamsi-amazon pushed a commit that referenced this pull request Apr 6, 2023
@opensearch-trigger-bot
REST API for GET,PUT and DELETE (#1482) (#1501)
89717e3 
* REST API for GET,PUT and DELETE

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
acarbonetto pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 18, 2023
@vamsi-amazon @acarbonetto
Fix conflicts: REST API for GET,PUT and DELETE (opensearch-project#1482)
066e8cd 
* REST API for GET,PUT and DELETE

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* changed permission action names

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

---------

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-chen dai-chen dai-chen approved these changes

@rupal-bq rupal-bq rupal-bq approved these changes

@penghuo penghuo penghuo left review comments

@YANG-DB YANG-DB YANG-DB left review comments

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

Assignees

@vamsi-amazon vamsi-amazon

Labels
backport 2.x backport 2.7 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]Update Datasource API [FEATURE]Get Datasource API [FEATURE] Delete Datasource API
6 participants
@vamsi-amazon @codecov-commenter @penghuo @dai-chen @YANG-DB @rupal-bq