Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding reflections as a dependency #1561

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

dhrubo-os
Copy link
Contributor

@dhrubo-os dhrubo-os commented Apr 19, 2023

Description

Backport for #1559

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os requested a review from a team as a code owner April 19, 2023 20:45
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #1561 (155952c) into 2.7 (1b104f6) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.7    #1561   +/-   ##
=========================================
  Coverage     97.18%   97.18%           
- Complexity     4098     4104    +6     
=========================================
  Files           371      371           
  Lines         10445    10459   +14     
  Branches        703      706    +3     
=========================================
+ Hits          10151    10165   +14     
  Misses          287      287           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the bug Something isn't working label Apr 19, 2023
@dai-chen dai-chen merged commit 6cfe354 into opensearch-project:2.7 Apr 19, 2023
13 of 14 checks passed
@dai-chen dai-chen mentioned this pull request Apr 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants