Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1586 to 1.3 branch #1617

Merged
merged 1 commit into from
May 9, 2023
Merged

Backport #1586 to 1.3 branch #1617

merged 1 commit into from
May 9, 2023

Conversation

pjfitzgibbons
Copy link

Description

Backport #1586 to 1.3 branch

Bumped org.json version in all submodules for CVE fix
Fixed failed UT and IT assertion due to breaking changes in Change the underflying storage for floating point numbers to BigDecimal stleary/JSON-java#441 (more details below)

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Merging #1617 (7ffe30e) into 1.3 (53625a1) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                1.3    #1617   +/-   ##
=========================================
  Coverage     95.25%   95.25%           
  Complexity     2746     2746           
=========================================
  Files           276      276           
  Lines          7416     7416           
  Branches        544      544           
=========================================
  Hits           7064     7064           
  Misses          298      298           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pjfitzgibbons pjfitzgibbons merged commit 0c2ba70 into 1.3 May 9, 2023
18 of 21 checks passed
@dai-chen
Copy link
Collaborator

dai-chen commented May 9, 2023

Should we backport this to 1.x branch?

opensearch-trigger-bot bot pushed a commit that referenced this pull request May 9, 2023
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
(cherry picked from commit 0c2ba70)
dai-chen pushed a commit that referenced this pull request May 10, 2023
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
(cherry picked from commit 0c2ba70)

Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants