Enable Table Function and PromQL function #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1719 +/- ##
============================================
+ Coverage 97.30% 97.33% +0.03%
- Complexity 4326 4405 +79
============================================
Files 385 388 +3
Lines 10807 10935 +128
Branches 762 771 +9
============================================
+ Hits 10516 10644 +128
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vamsi-amazon
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
rupal-bq
previously approved these changes
Jun 8, 2023
|
I forgot why we disabled this in PPL earlier? |
@dai-chen There was no UX on dashboards for table functions during 2.4 release. With spark sql we are building UX to handle table functions. |
Yury-Fridlyand
previously approved these changes
Jun 9, 2023
| -> { | ||
| String argName = (arg.ident() != null) ? arg.ident().getText() : null; | ||
| builder.add( | ||
| new UnresolvedArgument(argName, |
There was a problem hiding this comment.
When argName could be null? Are you protected from NPE when it is used?
ppl/src/main/java/org/opensearch/sql/ppl/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
penghuo
previously approved these changes
Jun 9, 2023
vamsi-amazon
dismissed stale reviews from penghuo, Yury-Fridlyand, and rupal-bq
via
a8d0ea2
vamsi-amazon
force-pushed
the
enable-table-function
branch
3 times, most recently
from
585adba
to
fa3f6d9
Compare
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon
force-pushed
the
enable-table-function
branch
from
fa3f6d9
to
65fdc83
Compare
ps48
approved these changes
Jun 15, 2023
penghuo
approved these changes
Jun 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Enable PromQL function Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Enable table function Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit af7bccb)
vamsi-amazon
pushed a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable Table function and promQL function. This also enables to build spark sql function.
Issues Resolved
#1019
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.