-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backticks on by
field in stats
#1728
Remove backticks on by
field in stats
#1728
Conversation
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@vamsi-amazon is it expected to have output fields in backticks for
i thought it's a bug but seems tests is expecting fields with backticks? sql/integ-test/src/test/java/org/opensearch/sql/ppl/PrometheusDataSourceCommandsIT.java Lines 110 to 117 in 4e9ca01
|
Codecov Report
@@ Coverage Diff @@
## main #1728 +/- ##
=========================================
Coverage 97.33% 97.33%
Complexity 4408 4408
=========================================
Files 388 388
Lines 10938 10939 +1
Branches 773 773
=========================================
+ Hits 10647 10648 +1
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Joshua Li <joshuali925@gmail.com>
confirmed with vamsi the tests can be changed. BWC is failing, error seems irrelevant to this PR
|
@@ -282,6 +282,27 @@ public void testStatsCommandWithByClause() { | |||
)); | |||
} | |||
|
|||
@Test | |||
public void testStatsCommandWithByClauseInBackticks() { | |||
assertEqual("source=t | stats count(a) by `b` DEDUP_SPLITVALUES=false", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the query is
"source = t | stats count(a) by `t.b` "
it would treat t.b as column name.
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 7525bb1)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 7525bb1) Co-authored-by: Joshua Li <joshuali925@gmail.com>
Description
Current behavior:
This PR will change it to
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.