Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new datetime functions and aliases to PPL [Part 2] #1852

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Added new datetime functions and aliases to PPL [Part 2] #1852

merged 1 commit into from
Jul 14, 2023

Conversation

matthewryanwells
Copy link
Contributor

Description

This PR adds multiple datetime functions that are in SQL to PPL.

The following functions are added:

  • get_format
  • last_day
  • sec_to_time
  • yearweek
  • weekday
  • to_seconds
  • str_to_date
  • timestampadd
  • timestampdiff
  • extract

Issues Resolved

No related issue

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@matthewryanwells
Added new datetime functions and aliases to PPL [Part 2] (#283)
a07adc8 
* Added new datetime functions, documentation, and tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1852 (a07adc8) into main (f5031a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1852   +/-   ##
=========================================
  Coverage     97.39%   97.39%           
- Complexity     4600     4606    +6     
=========================================
  Files           401      401           
  Lines         11381    11403   +22     
  Branches        843      843           
=========================================
+ Hits          11084    11106   +22     
  Misses          290      290           
  Partials          7        7
Flag Coverage Δ
sql-engine 97.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pensearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)

@MaxKsyunz MaxKsyunz merged commit 8c8e08c into opensearch-project:main Jul 14, 2023
16 checks passed
@MaxKsyunz MaxKsyunz deleted the integ-ppl-function-support-part2 branch July 14, 2023 17:05
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 14, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 14, 2023
@matthewryanwells @github-actions
Added new datetime functions and aliases to PPL [Part 2] (#283) (#1852)
a3d6469 
* Added new datetime functions, documentation, and tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8c8e08c)
matthewryanwells added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 14, 2023
@matthewryanwells
Added new datetime functions and aliases to PPL [Part 2] (#283) (open…
9352312 
…search-project#1852)

* Added new datetime functions, documentation, and tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
@matthewryanwells @MitchellGale
Added new datetime functions and aliases to PPL [Part 2] (#283) (open…
ad6de71 
…search-project#1852)

* Added new datetime functions, documentation, and tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
@matthewryanwells @MitchellGale
Added new datetime functions and aliases to PPL [Part 2] (#283) (open…
c4552de 
…search-project#1852)

* Added new datetime functions, documentation, and tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Jul 27, 2023
@matthewryanwells @Yury-Fridlyand
Added new datetime functions and aliases to PPL [Part 2] (#283) (#1852)
76a5874 
* Added new datetime functions, documentation, and tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8c8e08c)
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 28, 2023
@matthewryanwells @MitchellGale
Added new datetime functions and aliases to PPL [Part 2] (#283) (open…
6f4af48 
…search-project#1852)

* Added new datetime functions, documentation, and tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq rupal-bq is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewryanwells @Yury-Fridlyand @acarbonetto @MaxKsyunz