Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Session limitation #2354

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Add Session limitation #2354

merged 2 commits into from
Oct 25, 2023

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 25, 2023 •
edited
Loading

Description

  1. Update doc. https://github.com/opensearch-project/sql/blob/50f24ca9c8de49668104d325475e89bb91429ae2/docs/user/admin/settings.rst
  2. plugins.query.executionengine.spark.session.limit is applied to each datasource.

Issues Resolved

#2344

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo
add session creation limitation
023effb 
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo
add doc
50f24ca 
Signed-off-by: Peng Huo <penghuo@gmail.com>
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #2354 (50f24ca) into main (a27e733) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 92.68%.

@@             Coverage Diff              @@
##               main    #2354      +/-   ##
============================================
- Coverage     96.46%   96.45%   -0.02%     
- Complexity     4898     4906       +8     
============================================
  Files           464      464              
  Lines         13421    13466      +45     
  Branches        903      908       +5     
============================================
+ Hits          12946    12988      +42     
- Misses          456      458       +2     
- Partials         19       20       +1
Flag Coverage Δ
sql-engine 96.45% <92.68%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rch/sql/opensearch/setting/OpenSearchSettings.java 100.00% <100.00%> (ø)
...ch/sql/spark/execution/session/SessionManager.java 100.00% <100.00%> (ø)
...rch/sql/spark/execution/statestore/StateStore.java 81.88% <89.65%> (+2.06%) ⬆️

... and 1 file with indirect coverage changes

@penghuo penghuo merged commit a2014ee into opensearch-project:main Oct 25, 2023
19 of 21 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 25, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@github-actions
Add Session limitation (#2354)
58559da 
* add session creation limitation

Signed-off-by: Peng Huo <penghuo@gmail.com>

* add doc

Signed-off-by: Peng Huo <penghuo@gmail.com>

---------

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit a2014ee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 25, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@github-actions
Add Session limitation (#2354)
41bd845 
* add session creation limitation

Signed-off-by: Peng Huo <penghuo@gmail.com>

* add doc

Signed-off-by: Peng Huo <penghuo@gmail.com>

---------

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit a2014ee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Oct 25, 2023
@opensearch-trigger-bot @github-actions
Add Session limitation (#2354) (#2358)
c211380 
* add session creation limitation



* add doc



---------


(cherry picked from commit a2014ee)

Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Oct 25, 2023
@opensearch-trigger-bot @github-actions
Add Session limitation (#2354) (#2359)
0f334f8 
* add session creation limitation



* add doc



---------


(cherry picked from commit a2014ee)

Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/sql that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Add Session limitation (opensearch-project#2354) (opensearch-…
4248946 
…project#2359)"

This reverts commit 0f334f8.

Signed-off-by: Eric <menwe@amazon.com>
mengweieric added a commit to mengweieric/sql that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Add Session limitation (opensearch-project#2354) (opensearch-…
1c8bd0e 
…project#2359)"

This reverts commit 0f334f8.

Signed-off-by: Eric <menwe@amazon.com>
vamsi-amazon added a commit to mengweieric/sql that referenced this pull request Nov 13, 2023
@vamsi-amazon
Revert "Add Session limitation (opensearch-project#2354) (opensearch-…
d420e73 
…project#2359)"

This reverts commit 0f334f8.
vamsi-amazon added a commit that referenced this pull request Nov 13, 2023
@mengweieric @vamsi-amazon
Revert commits back to after 2.11 release (#2427)
62d3940 
* Revert "Add more metrics and handle emr exception message (#2422) (#2426)"

This reverts commit b57f7cc.

* Revert "Block settings in sql query settings API and add more unit tests (#2407) (#2412)"

This reverts commit 3024737.

* Revert "Added session, statement, emrjob metrics to sql stats api (#2398) (#2400)"

This reverts commit 6e17ae6.

* Revert "Redefine Drop Index as logical delete (#2386) (#2397)"

This reverts commit e939bb6.

* Revert "add concurrent limit on datasource and sessions (#2390) (#2395)"

This reverts commit deb3ccf.

* Revert "Add Flint Index Purging Logic (#2372) (#2389)"

This reverts commit dd48b9b.

* Revert "Refactoring for tags usage in test files and also added explicit denly list setting. (#2383) (#2385)"

This reverts commit 37e010f.

* Revert "Enable session by default (#2373) (#2375)"

This reverts commit 7d95e4c.

* Revert "Create new session if client provided session is invalid (#2368) (#2371)"

This reverts commit 5ab7858.

* Revert "Add where clause support in create statement (#2366) (#2370)"

This reverts commit b620a56.

* Revert "create new session if current session not ready (#2363) (#2365)"

This reverts commit 5d07281.

* Revert "Handle Describe,Refresh and Show Queries Properly (#2357) (#2362)"

This reverts commit 16e2f30.

* Revert "Add Session limitation (#2354) (#2359)"

This reverts commit 0f334f8.

* Revert "Bug Fix, support cancel query in running state (#2351) (#2353)"

This reverts commit 9a40591.

* Revert "Fix bug, using basic instead of basicauth (#2342) (#2355)"

This reverts commit e4827a5.

* Revert "Add missing tags and MV support (#2336) (#2346)"

This reverts commit 8791bb0.

* Revert "[Backport 2.x] deprecated job-metadata-index (#2340) (#2343)"

This reverts commit bea432c.

* Revert "Integration with REPL Spark job (#2327) (#2338)"

This reverts commit 58a5ae5.

* Revert "Implement patch API for datasources (#2273) (#2329)"

This reverts commit 4c151fe.

* Revert "Add sessionId parameters for create async query API (#2312) (#2324)"

This reverts commit 3d1a376.

* Revert "Add Statement (#2294) (#2318) (#2319)"

This reverts commit b3c2e94.

* Revert "Upgrade json (#2307) (#2314)"

This reverts commit 6c65bb4.

* Revert "Minor Refactoring (#2308) (#2317)"

This reverts commit 051cc4f.

* Revert "add InteractiveSession and SessionManager (#2290) (#2293) (#2315)"

This reverts commit 6ac197b.

---------

Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiddis Swiddis Swiddis approved these changes

@dai-chen dai-chen dai-chen approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq rupal-bq is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@penghuo @Swiddis @dai-chen @YANG-DB