Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [2.x] Update to Gradle 8.4 (#2433) #2480

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[Backport] [2.x] Update to Gradle 8.4 (#2433) #2480

merged 1 commit into from
Jan 25, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Jan 25, 2024

Backport of #2433 to 2.x

@reta reta mentioned this pull request Jan 25, 2024
Closed
95 tasks
@reta reta force-pushed the backport/backport-2433-to-2.x branch from 9dc2d4a to 4f1dd97 Compare January 25, 2024 14:53
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (894639a) 95.46% compared to head (a2a5e11) 95.46%.

Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x    #2480   +/-   ##
=========================================
  Coverage     95.46%   95.46%           
  Complexity     5037     5037           
=========================================
  Files           480      480           
  Lines         14106    14106           
  Branches        940      940           
=========================================
  Hits          13466    13466           
  Misses          618      618           
  Partials         22       22
Flag Coverage Δ
sql-engine 95.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Update to Gradle 8.4 (opensearch-project#2433)
a2a5e11 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 6f30aea)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the backport/backport-2433-to-2.x branch from 4f1dd97 to a2a5e11 Compare January 25, 2024 15:20
@reta
Copy link
Contributor Author

reta commented Jan 25, 2024

I believe test failures are addressed in #2476

@vamsi-amazon
Copy link
Member

This PR merge necessary for unblocking the build. So merging this.

@joshuali925 joshuali925 merged commit bad7703 into opensearch-project:2.x Jan 25, 2024
18 of 28 checks passed
@vamsi-amazon
Copy link
Member

@reta can I understand why 21 is added explicitly added to 2.x before main? Is this accidental?

@reta
Copy link
Contributor Author

reta commented Feb 6, 2024 •
edited
Loading

@reta can I understand why 21 is added explicitly added to 2.x before main? Is this accidental?

@vamsi-amazon it is not accidental, the pull request for main is sitting 2 weeks without attention here #2481, the 2.x was backported JDK-21 and Gradle 8.4 in one shot, to get ready to 2.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@vamsi-amazon vamsi-amazon vamsi-amazon approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq rupal-bq is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reta @vamsi-amazon @joshuali925