Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set baseline JDK version to JDK-21 #2787

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

manasvinibs
Copy link
Member

@manasvinibs manasvinibs commented Jun 28, 2024

Description

Sets the baseline JDK version to JDK-21

Issues Resolved

#2713

@noCharger
Copy link
Contributor

let's fix CI and security check, thanks!

@manasvinibs
Copy link
Member Author

let's fix CI and security check, thanks!

Looks like Whitesource security check scanner has failed to scan the repo and seems unrelated to this change.

For BWC test failure here https://github.com/opensearch-project/sql/actions/runs/9719035598/job/26828118379?pr=2787

I see below error

Execution failed for task ':integ-test:sqlBwcCluster#mixedClusterTask'.
> `cluster{:integ-test:sqlBwcCluster0}` failed to wait for cluster health yellow after 40 SECONDS
    IO error while waiting cluster
    503 Service Unavailable

which also seems to be not related to the upgrade change. Can you help me understand how can I fix this if it is related to my change?

@ykmr1224
Copy link
Collaborator

I saw similar bwc test failure before, and @derek-ho fixed that in #2662
I think it was partially caused by version mismatch with ml-commons plugin

@noCharger
Copy link
Contributor

let's fix CI and security check, thanks!

Looks like Whitesource security check scanner has failed to scan the repo and seems unrelated to this change.

For BWC test failure here https://github.com/opensearch-project/sql/actions/runs/9719035598/job/26828118379?pr=2787

I see below error

Execution failed for task ':integ-test:sqlBwcCluster#mixedClusterTask'.
> `cluster{:integ-test:sqlBwcCluster0}` failed to wait for cluster health yellow after 40 SECONDS
    IO error while waiting cluster
    503 Service Unavailable

which also seems to be not related to the upgrade change. Can you help me understand how can I fix this if it is related to my change?

Could you rerun whitesource? As per the CI, could you try :integ-test:sqlBwcCluster#mixedClusterTask locally?

@manasvinibs
Copy link
Member Author

let's fix CI and security check, thanks!

Looks like Whitesource security check scanner has failed to scan the repo and seems unrelated to this change.
For BWC test failure here https://github.com/opensearch-project/sql/actions/runs/9719035598/job/26828118379?pr=2787
I see below error

Execution failed for task ':integ-test:sqlBwcCluster#mixedClusterTask'.
> `cluster{:integ-test:sqlBwcCluster0}` failed to wait for cluster health yellow after 40 SECONDS
    IO error while waiting cluster
    503 Service Unavailable

which also seems to be not related to the upgrade change. Can you help me understand how can I fix this if it is related to my change?

Could you rerun whitesource? As per the CI, could you try :integ-test:sqlBwcCluster#mixedClusterTask locally?

Yes in local I see this error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':integ-test:sqlBwcCluster#oldVersionClusterTask0'.
> Could not resolve all files for configuration ':integ-test:opensearch_distro_extracted_testclusters-integ-test-sqlBwcCluster0-0-2.15.0-'.
   > Could not resolve opensearch-distribution:opensearch:2.15.0.
     Required by:
         project :integ-test
      > Could not resolve opensearch-distribution:opensearch:2.15.0.
         > Could not get resource 'https://artifacts.opensearch.org/releases/core/opensearch/2.15.0/opensearch-min-2.15.0-darwin-x64.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/releases/core/opensearch/2.15.0/opensearch-min-2.15.0-darwin-x64.tar.gz'. Received status code 403 from server: Forbidden
      > Could not resolve opensearch-distribution:opensearch:2.15.0.
         > Could not get resource 'https://artifacts.opensearch.org/release-candidates/core/opensearch/2.15.0/opensearch-min-2.15.0-darwin-x64.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/release-candidates/core/opensearch/2.15.0/opensearch-min-2.15.0-darwin-x64.tar.gz'. Received status code 403 from server: Forbidden

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.4/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 2s

Similar to Derek's PR, this seems to be related to not finding the artifacts for Darwin x64 platform.

@manasvinibs
Copy link
Member Author

@peterzhuamazon Hi Peter, we are having BWC test failures in our CI because of not finding Darwin artifacts for 2.15. Is this known issue?

@penghuo
Copy link
Collaborator

penghuo commented Jul 1, 2024

@peterzhuamazon Hi Peter, we are having BWC test failures in our CI because of not finding Darwin artifacts for 2.15. Is this known issue?

Test is on Linux, not related MacOS

Should we bump String baseVersion = "2.15.0" to 2.16.0 now?

@penghuo
Copy link
Collaborator

penghuo commented Jul 1, 2024

Depend on #2743

@derek-ho
Copy link
Collaborator

derek-ho commented Jul 2, 2024

@peterzhuamazon Hi Peter, we are having BWC test failures in our CI because of not finding Darwin artifacts for 2.15. Is this known issue?

Test is on Linux, not related MacOS

Should we bump String baseVersion = "2.15.0" to 2.16.0 now?

Yes the base version should be bumped

Signed-off-by: Manasvini B S <manasvis@amazon.com>
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@penghuo penghuo merged commit 81ae699 into opensearch-project:main Jul 2, 2024
11 of 12 checks passed
@dai-chen
Copy link
Collaborator

@manasvinibs This PR incorporates many changes in ANTLR grammar automatically. Can we backport this 2.x branch?

If concern, I think we need to create a PR manually with only grammar changes. Otherwise, we may miss those changes in all 2.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants