Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license header #282

Merged
merged 7 commits into from
Nov 12, 2021
Merged

Conversation

joshuali925
Copy link
Member

Description

#175

Issues Resolved

#175

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #282 (3125416) into main (65f449b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #282   +/-   ##
=========================================
  Coverage     99.90%   99.90%           
  Complexity     2687     2687           
=========================================
  Files           256      256           
  Lines          6524     6524           
  Branches        420      420           
=========================================
  Hits           6518     6518           
  Misses            5        5           
  Partials          1        1           
Impacted Files Coverage Δ
...a/org/opensearch/sql/analysis/AnalysisContext.java 100.00% <ø> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <ø> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <ø> (ø)
...rch/sql/analysis/ExpressionReferenceOptimizer.java 100.00% <ø> (ø)
...ensearch/sql/analysis/NamedExpressionAnalyzer.java 100.00% <ø> (ø)
...org/opensearch/sql/analysis/QualifierAnalyzer.java 100.00% <ø> (ø)
...nsearch/sql/analysis/SelectExpressionAnalyzer.java 100.00% <ø> (ø)
...a/org/opensearch/sql/analysis/TypeEnvironment.java 100.00% <ø> (ø)
...nsearch/sql/analysis/WindowExpressionAnalyzer.java 100.00% <ø> (ø)
.../org/opensearch/sql/analysis/symbol/Namespace.java 100.00% <ø> (ø)
... and 237 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f449b...3125416. Read the comment docs.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 marked this pull request as ready for review November 12, 2021 01:58
anirudha
anirudha previously approved these changes Nov 12, 2021
Copy link
Collaborator

@anirudha anirudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@anirudha anirudha merged commit 907019c into opensearch-project:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants