-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BI connectors and drivers readme files #665
Update BI connectors and drivers readme files #665
Conversation
… links. Add BI connectors binaries. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Update BI connectors and drivers readme files
Codecov Report
@@ Coverage Diff @@
## main #665 +/- ##
=========================================
Coverage 94.70% 94.70%
Complexity 2825 2825
=========================================
Files 282 282
Lines 7609 7609
Branches 558 558
=========================================
Hits 7206 7206
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
|
||
<img src="img/tableau_select_connector.png" width=600> | ||
|
||
* Enter **Server** & **Port** value. | ||
* Select required authentication option. For **AWS_SIGV4** authentication, select **Integrated Authentication** and enter value for **Region**. To setup aws access key id and secret key, create ~/.aws/credentials with [AWS CLI](https://aws.amazon.com/cli/) and use `opensearchodbc` as the profile name. | ||
* Select required authentication option. For **AWS_SIGV4** authentication, select **AWS_SIGv4** and enter value for **Region**. You need to create `~/.aws/credentials` and add `default` profile with aws access key id and secret key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: would ODBC drivers use default
or still opensearchodbc
profile? if still opensearchodbc
i think it's better to keep it documented somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! ODBC
driver still require opensearchodbc
profile due to the bug, but Tableau uses JDBC
driver which works with default
profile. So there is no mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. after removing that information here, users won't be able to know that ODBC
driver still require opensearchodbc
because no other place mentions it
I'm saying should the information be documented somewhere else? maybe in https://github.com/opensearch-project/sql/blob/main/sql-odbc/docs/user/configuration_options.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 7694813.
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Description
Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com
Issues Resolved
Fixes:
#605
#607
#629
#439
#340
#246
#257
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.