Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cursor enabling and fetch size setting #75

Merged

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented May 19, 2021

Description

  1. Remove old opendistro.sql.cursor.enabled and opendistro.sql.cursor.fetch_size setting
  2. [Breaking Change] Change the behavior when fetch_size is absent:
    a. Before changes: open cursor with size read from fetch size setting above
    b. After changes: no cursor context created (same behavior as fetch_size=0)

The reason why to make this breaking change is that cursor support is missing in the new SQL engine. If pagination is expected in the absence of fetch_size, all queries will fallback to old engine (once cursor enabled).

Issues Resolved

#60
opendistro-for-elasticsearch/sql#1081 (comment)

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added the SQL label May 19, 2021
@dai-chen dai-chen self-assigned this May 19, 2021
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants