Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated ClusterService and Using NodeClient to fetch meta data #774

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Aug 17, 2022

Signed-off-by: penghuo penghuo@gmail.com

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo penghuo requested a review from a team as a code owner August 17, 2022 22:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #774 (699f0ac) into 2.1 (808813d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.1     #774      +/-   ##
============================================
- Coverage     97.71%   97.71%   -0.01%     
  Complexity     2801     2801              
============================================
  Files           270      271       +1     
  Lines          6912     6908       -4     
  Branches        439      438       -1     
============================================
- Hits           6754     6750       -4     
  Misses          157      157              
  Partials          1        1              
Flag Coverage Δ
sql-engine 97.71% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <100.00%> (ø)
.../opensearch/sql/opensearch/executor/Scheduler.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo merged commit 0576d96 into opensearch-project:2.1 Aug 18, 2022
@penghuo penghuo deleted the 2.1-deprecated-clusterService branch August 18, 2022 00:33
penghuo added a commit to penghuo/os-sql that referenced this pull request Aug 30, 2022
penghuo added a commit that referenced this pull request Aug 31, 2022
@penghuo penghuo mentioned this pull request Mar 27, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants