Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change master node timeout to new API #793

Merged

Conversation

dai-chen
Copy link
Collaborator

Signed-off-by: Chen Dai daichen@amazon.com

Description

Change masterNodeTimeout to new API clusterManagerNodeTimeout.

Issues Resolved

#463

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen self-assigned this Aug 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #793 (e984b07) into main (eeb90cf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #793   +/-   ##
=========================================
  Coverage     94.85%   94.85%           
  Complexity     2913     2913           
=========================================
  Files           288      288           
  Lines          7839     7839           
  Branches        571      571           
=========================================
  Hits           7436     7436           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen marked this pull request as ready for review August 30, 2022 21:02
@dai-chen dai-chen requested a review from a team as a code owner August 30, 2022 21:02
Signed-off-by: Chen Dai <daichen@amazon.com>
Copy link
Collaborator

@anirudha anirudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dai-chen dai-chen merged commit 4e40ed2 into opensearch-project:main Sep 1, 2022
@dai-chen dai-chen deleted the change-master-timeout-nomenclature branch September 1, 2022 22:44
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2022
* Change master timeout to new API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Change param name to cluster_manager_timeout

Signed-off-by: Chen Dai <daichen@amazon.com>

Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 4e40ed2)
dai-chen added a commit that referenced this pull request Sep 7, 2022
* Change master timeout to new API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Change param name to cluster_manager_timeout

Signed-off-by: Chen Dai <daichen@amazon.com>

Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 4e40ed2)

Co-authored-by: Chen Dai <daichen@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants