Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forum link in SQL plugin README.md #809

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Sep 8, 2022

Signed-off-by: cwillum cwmmoore@amazon.com

Description

Added Forum header section that includes verbiage and a link to the OpenSearch Forum page for the SQL plugin.

Issues Resolved

This more closely corresponds to the information found in the README.md file in all of the other plugins bundled with OpenSearch.

This fixes the issue for the SQL plugin in #921.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: cwillum <cwmmoore@amazon.com>
README.md Outdated Show resolved Hide resolved
Signed-off-by: cwillum <cwmmoore@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #809 (17783a6) into main (ddb3deb) will increase coverage by 32.05%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #809       +/-   ##
=============================================
+ Coverage     62.76%   94.82%   +32.05%     
- Complexity        0     2912     +2912     
=============================================
  Files            10      291      +281     
  Lines           658     7783     +7125     
  Branches        118      566      +448     
=============================================
+ Hits            413     7380     +6967     
- Misses          192      349      +157     
- Partials         53       54        +1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/opensearch/sql/expression/LiteralExpression.java 100.00% <0.00%> (ø)
...arch/storage/script/filter/lucene/LuceneQuery.java 100.00% <0.00%> (ø)
...h/sql/expression/conditional/cases/WhenClause.java 100.00% <0.00%> (ø)
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <0.00%> (ø)
...ression/operator/arthmetic/ArithmeticFunction.java 100.00% <0.00%> (ø)
...ch/planner/logical/rule/MergeSortAndIndexScan.java 100.00% <0.00%> (ø)
...nsearch/data/value/OpenSearchExprValueFactory.java 100.00% <0.00%> (ø)
...arch/sql/expression/aggregation/AvgAggregator.java 100.00% <0.00%> (ø)
...org/opensearch/sql/analysis/HighlightAnalyzer.java 100.00% <0.00%> (ø)
...nsearch/response/error/OpenSearchErrorMessage.java 100.00% <0.00%> (ø)
... and 271 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dai-chen
dai-chen previously approved these changes Sep 8, 2022
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen added the documentation Improvements or additions to documentation label Sep 8, 2022
@cwillum
Copy link
Contributor Author

cwillum commented Sep 9, 2022

@opensearch-project/sql Thanks for the review. And sorry to break the SQL Java CI check. When that's resolved and the reviews are complete, could someone merge this PR? I don't have that permission in this repo. Thanks.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
MaxKsyunz
MaxKsyunz previously approved these changes Sep 10, 2022
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum dismissed stale reviews from MaxKsyunz and dai-chen via 17783a6 September 12, 2022 17:37
@MaxKsyunz MaxKsyunz merged commit ac011ce into opensearch-project:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants