Restricted catalog name to [a-zA-Z0-9_-] characters

[vamsi-amazon]

Signed-off-by: vamsi-amazon reddyvam@amazon.com

Description

Restricting catalog name to [a-zA-Z0-9_-] characters.

Issues Resolved

#619

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  Will raise document PR separately.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #876 (281fc59) into 2.x (c04c784) will decrease coverage by 2.80%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #876      +/-   ##
============================================
- Coverage     97.88%   95.08%   -2.81%     
- Complexity     3049     3059      +10     
============================================
  Files           290      303      +13     
  Lines          7534     8213     +679     
  Branches        480      601     +121     
============================================
+ Hits           7375     7809     +434     
- Misses          158      350     +192     
- Partials          1       54      +53     

Flag	Coverage Δ
query-workbench	62.76% <ø> (?)
sql-engine	97.89% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ain/java/org/opensearch/sql/analysis/Analyzer.java	100.00% <100.00%> (ø)
...org/opensearch/sql/analysis/model/CatalogName.java	100.00% <100.00%> (ø)
...ql/analysis/model/CatalogSchemaIdentifierName.java	100.00% <100.00%> (ø)
.../org/opensearch/sql/analysis/model/SchemaName.java	100.00% <100.00%> (ø)
...ensearch/sql/ppl/utils/PPLQueryDataAnonymizer.java	100.00% <100.00%> (ø)
workbench/public/application.tsx	0.00% <0.00%> (ø)
workbench/public/components/app.tsx	0.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx	85.71% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx	100.00% <0.00%> (ø)
workbench/public/components/PPLPage/PPLPage.tsx	56.52% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dai-chen]

IMHO, we need to define catalog clearly including:

1. The definition of this concept
2. Relation with connector (ex. N-to-1)
3. Identifier match pattern
4. Name resolution: https://docs.snowflake.com/en/sql-reference/name-resolution.html
5. Access path: SHOW/DESC statement (information_schema underlying)

[vamsi-amazon]

IMHO, we need to define catalog clearly including:

1. The definition of this concept

2. Relation with connector (ex. N-to-1)

3. Identifier match pattern

4. Name resolution: https://docs.snowflake.com/en/sql-reference/name-resolution.html

5. Access path: SHOW/DESC statement (`information_schema` underlying)

will create a doc for catalog under current documentation.

[penghuo]

why tableau_graph.PNG is removed?

[vamsi-amazon]

why tableau_graph.PNG is removed?

Not sure my repos are messed up with respect to this file...got included in the latest version.
will fix thanks for pointing out.

[penghuo]

Thanks for the change!

[penghuo]

Could you also update the doc to describe identifier resolve rule?

[dai-chen]

For PR description, could you follow the practice to link issue and check items applied?

[vamsi-amazon]

For PR description, could you follow the practice to link issue and check items applied?

Sure