Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Connector Initial Code #878

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Oct 3, 2022

Signed-off-by: vamsi-amazon reddyvam@amazon.com

Description

This CR Includes PrometheusMetricScan and other basic boilerplate code to connect to prometheus.

Issues Resolved

#620

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vamsi-amazon vamsi-amazon force-pushed the prom-connector branch 2 times, most recently from e4d47b6 to 9053148 Compare October 3, 2022 06:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Merging #878 (182ef76) into 2.x (057fa44) will decrease coverage by 2.80%.
The diff coverage is 99.08%.

@@             Coverage Diff              @@
##                2.x     #878      +/-   ##
============================================
- Coverage     97.87%   95.06%   -2.81%     
- Complexity     3020     3049      +29     
============================================
  Files           284      300      +16     
  Lines          7425     8192     +767     
  Branches        475      599     +124     
============================================
+ Hits           7267     7788     +521     
- Misses          157      350     +193     
- Partials          1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.88% <99.08%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...theus/data/constants/PrometheusFieldConstants.java 0.00% <0.00%> (ø)
...ch/sql/prometheus/client/PrometheusClientImpl.java 100.00% <100.00%> (ø)
...theus/request/PrometheusDescribeMetricRequest.java 100.00% <100.00%> (ø)
...sql/prometheus/request/PrometheusQueryRequest.java 100.00% <100.00%> (ø)
...ch/sql/prometheus/response/PrometheusResponse.java 100.00% <100.00%> (ø)
...h/sql/prometheus/storage/PrometheusMetricScan.java 100.00% <100.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)
workbench/public/components/Main/main.tsx 53.00% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vamsi-amazon vamsi-amazon marked this pull request as ready for review October 3, 2022 07:19
@vamsi-amazon vamsi-amazon requested a review from a team as a code owner October 3, 2022 07:19
anirudha
anirudha previously approved these changes Oct 3, 2022
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! A minor comment: please add javadoc to PrometheusClient since it's a core class.

@dai-chen
Copy link
Collaborator

dai-chen commented Oct 6, 2022

Link #623 and #620 ?

It maybe helpful for community and us to track by adding this to #561

Linked will mention these in 561.

@vamsi-amazon
Copy link
Member Author

Thanks for the changes! A minor comment: please add javadoc to PrometheusClient since it's a core class.

Will add in the new PR. might require additional approvals.

@vamsi-amazon vamsi-amazon merged commit c04c784 into opensearch-project:2.x Oct 6, 2022
@vamsi-amazon vamsi-amazon linked an issue Oct 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants