Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs - missing changes for #754. #884

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Oct 4, 2022

Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com

Description

I had a big code rework in #754 and removed fsp argument for most of functions. Unfortunately, I forgot to update the docs.
Thanks @MitchellGale-BitQuill for finding.

UPD

Reorder functions

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 4, 2022 04:30
@codecov-commenter

This comment was marked as spam.

penghuo
penghuo previously approved these changes Oct 4, 2022
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
@dai-chen dai-chen added the documentation Improvements or additions to documentation label Oct 11, 2022
@dai-chen dai-chen merged commit 46aa656 into opensearch-project:2.x Oct 11, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the fix/docs-for-now-like-functions branch October 11, 2022 18:17
GabeFernandez310 pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 19, 2022
…-project#884)

* Update docs.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>

* Reorder functions in docs aplhabetically.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants