Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual CI workflow and add name option. #904

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com

Description

  • Fix manual CI workflow.
  • Add name optional parameter; If not given <branch name> @ <commit sha> is used.

Issues Resolved

Workflow ignored all test errors and reported always success. Workflow was introduced in #837.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand added infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. backport 1.x backport main labels Oct 12, 2022
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 12, 2022 06:08
@Yury-Fridlyand
Copy link
Collaborator Author

image
image

@@ -2,6 +2,13 @@ name: SQL Plugin Tests

on:
workflow_dispatch:
inputs:
name:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a description, maybe with example? <branch name> @ <commit sha>

@@ -2,6 +2,13 @@ name: SQL Plugin Tests

on:
workflow_dispatch:
inputs:
name:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we call this branch_commit or similar?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a custom run name which could be specified to override the default value. Default is <branch name> @ <commit sha>

@codecov-commenter

This comment was marked as spam.

@penghuo
Copy link
Collaborator

penghuo commented Oct 18, 2022

Workflow ignored all test errors and reported always success

What is the use case of the workflow?

@Yury-Fridlyand
Copy link
Collaborator Author

What is the use case of the workflow?

It is supposed to run on dev/dbg branches to get results from all tests. This workflow could be triggered manually only.

@penghuo
Copy link
Collaborator

penghuo commented Oct 27, 2022

Please do not backport to main which is not stable now.

@Yury-Fridlyand Yury-Fridlyand merged commit ccc2230 into opensearch-project:2.x Oct 27, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the fix-manual-workflow branch October 27, 2022 18:10
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-904-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccc223099f142386f260558d78b039dc50994d1f
# Push it to GitHub
git push --set-upstream origin backport/backport-904-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-904-to-1.x.

@Yury-Fridlyand
Copy link
Collaborator Author

Why backport always fail? Is something broken?

Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 28, 2022
…orkflow

Fix manual CI workflow and add `name` option.

(cherry picked from commit ccc2230)
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
penghuo pushed a commit that referenced this pull request Nov 7, 2022
Fix manual CI workflow and add `name` option.

(cherry picked from commit ccc2230)
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants