Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ignored and disabled tests #926

Merged

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Oct 18, 2022

Description

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Guian Gumpac added 9 commits October 12, 2022 11:30
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
…est and enabled can_serialize_and_deserialize_functions

Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
…stSortWithNullValue

Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
@GumpacG GumpacG requested a review from a team as a code owner October 18, 2022 17:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #926 (16f6714) into 2.x (c3840b6) will decrease coverage by 3.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #926      +/-   ##
============================================
- Coverage     97.90%   94.88%   -3.02%     
- Complexity     3072     3153      +81     
============================================
  Files           293      315      +22     
  Lines          7588     8532     +944     
  Branches        490      631     +141     
============================================
+ Hits           7429     8096     +667     
- Misses          158      382     +224     
- Partials          1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.57% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rch/planner/physical/MLCommonsOperatorActions.java 1.29% <0.00%> (-0.46%) ⬇️
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <0.00%> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <0.00%> (ø)
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <0.00%> (ø)
...ava/org/opensearch/sql/utils/SystemIndexUtils.java 100.00% <0.00%> (ø)
...rg/opensearch/sql/ppl/config/PPLServiceConfig.java 100.00% <0.00%> (ø)
...rg/opensearch/sql/sql/config/SQLServiceConfig.java 100.00% <0.00%> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <0.00%> (ø)
...opensearch/sql/planner/logical/LogicalPlanDSL.java 100.00% <0.00%> (ø)
...pensearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <0.00%> (ø)
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MaxKsyunz
MaxKsyunz previously approved these changes Oct 20, 2022
Copy link
Collaborator

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

acarbonetto
acarbonetto previously approved these changes Oct 20, 2022
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I left some comments for some re-enabled tests. Basically those cannot work functionally are safe to be enable now. I think the only concern is for others previously disabled due to flaky behavior. Please help double check. Thanks!

@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Oct 20, 2022
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
@GumpacG GumpacG dismissed stale reviews from acarbonetto and MaxKsyunz via 16f6714 October 27, 2022 19:18
@MaxKsyunz MaxKsyunz merged commit 3fd53ca into opensearch-project:2.x Oct 28, 2022
@MaxKsyunz MaxKsyunz deleted the integ-fix-disabled-sql-tests branch October 28, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants