Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed json-smart in the JDBC driver #978

Merged

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Oct 27, 2022

Signed-off-by: Guian Gumpac guiang@bitquilltech.com

Description

Removed json-smart in the jdbc driver as it introduces a CVE (CVE-2021-31684).

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
@GumpacG GumpacG requested a review from a team as a code owner October 27, 2022 17:14
@dai-chen dai-chen added JDBC dependencies Pull requests that update a dependency file labels Oct 27, 2022
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! So json-smart is useless actually?

@GumpacG
Copy link
Collaborator Author

GumpacG commented Oct 27, 2022

Thanks for the changes! So json-smart is useless actually?

Seems like it. Builds and passes all tests without it.

@MaxKsyunz MaxKsyunz merged commit ba97742 into opensearch-project:2.x Oct 27, 2022
@GumpacG GumpacG deleted the integ-remove-json-smart-in-jdbc branch November 4, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants