Update MacOS Version for ODBC Driver

[forestmvey]

Description

Updating MacOS from 10.15 to 12 poses compilation issues for libraries aws-sdk-cpp and googletest. A better solution than building from source is to manage dependencies through a package manager like vcpkg. Libraries rapidjson and rabbit I could not eliminate building from source completely. Windows failed to compile with VS 2022, and rabbit is not included in vcpkg.

Compilation Error Fixes -

VS 2022:

• Addition of <algorith> includes

error C2039: 'any_of': is not a member of 'std'

• Changes from std::string to Aws::String

error C2440: 'initializing': cannot convert from 'A
ws::String' to 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>'

XCode 13.3:

• Removal of basic_array(const basic_array& other) sql-odbc/libraries/rabbit/include/rabbit.hpp

src/../libraries/rabbit/include/rabbit.hpp:1153:3: error: definition of implicit copy assignment operator for 'basic_array<rabbit::details::value_ref_traits<rapidjson::UTF8<>>>' is deprecated because it has a user-provided copy constructor [-Werror,-Wdeprecated-copy-with-user-provided-copy]
  basic_array(const basic_array& other)

• Removal of bindpara_msg_to_utf8 function as it is never used, contains unused variables, and has potential for exploit when executing malloc(strlen(buff)) with a non-null terminated buffer.

• Multiple deletions for un-used variables made throughout.

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[MaxKsyunz]

LGTM!

[Yury-Fridlyand]

@penghuo, @dai-chen,
Do you want to backport this to fix CI on 2.4, 1.x and main?

[dai-chen]

@penghuo, @dai-chen, Do you want to backport this to fix CI on 2.4, 1.x and main?

Thanks for reminding! Just confirmed 2.4 has this commit. Because we may backport all changes in 2.x to main together, probably we only need to backport to 1.x now?

[Yury-Fridlyand]

I detected ODBC CI failed on main recently: https://github.com/opensearch-project/sql/actions/runs/3396132013
I also don't see this fix on main: https://github.com/opensearch-project/sql/commits/main
Please, double check me and label this PR if it looks good for you. I will backport manually if bot fail.

[dai-chen]

I detected ODBC CI failed on main recently: https://github.com/opensearch-project/sql/actions/runs/3396132013 I also don't see this fix on main: https://github.com/opensearch-project/sql/commits/main Please, double check me and label this PR if it looks good for you. I will backport manually if bot fail.

Yes, it is not in main. I meant we will need to merge all changes to main together soon. Not only this PR. So probably we just need to back port to 1.x for now?

[opensearch-trigger-bot]

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-987-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99cebe349710c6e2f3fecef8ddd1d9be488029c0
# Push it to GitHub
git push --set-upstream origin backport/backport-987-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-987-to-1.x.

[Yury-Fridlyand]

Ok I'll backport manually.