Newly introduced node properties don´t work as expected

[gregorkistler]

Today I´ve pulled the changes made a couple of days ago. I like the idea of having an internal communication between the UI and backend nodes and a public one only for user interaction like download.

After I´ve edited the settings of an existing node and left the value of the field Host / IP Address : Port For Downloads empty I couldn´t download anything anymore because my browser pointed to a file location like

http://download/821735ee68379684c0aad5c1e30c07677429b928?name=debian-8.7.1-arm64-netinst.iso

The field description seems not quite correct at the moment:

optional, leave empty if it's the same

Currently it doesn´t really matter if it´s the same or not. In any case it will lead to an empty value regarding the ip address/hostname/FQDN which of course ends in a download URL which doesn´t exist.

[xabolcs]

Oh! :(
Thanks for reporting.

[xabolcs]

It works for me. :(
What next?

Could you provide STR?

[xabolcs]

@gregorkistler please check my proposed fix on branch-issue-49-public-channel-isempty branch!

[gregorkistler]

Yes that solves it, thank you.
The field description would be still irritating as the field won´t stay empty after you´ve saved the form and edit it again but that´s okay for me.
Functionality matters :)

[xabolcs]

Thanks!

Empty field comes with another train! ;)

[xabolcs]

Fixed by commit ac26959.