Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipse and polyline support #426

Merged
merged 10 commits into from Jul 1, 2021
Merged

Ellipse and polyline support #426

merged 10 commits into from Jul 1, 2021

Conversation

nickgaray
Copy link
Collaborator

Refactored polyline support within CesiumView.js and added support for Ellipses

@nickgaray nickgaray requested a review from mdhsl June 4, 2021 21:19
* Prevent using setData when no function are defined
@mdhsl
Copy link
Member

mdhsl commented Jun 22, 2021

Thank you @nickgaray . I have modify a little bit your layer and fix a bug into the super class Layer.js.
Also, it seems now that you have changed the way you handle polylines and ellipses in Cesium. This now causes these features to blink.

After investigation, this blinking seems normal for Cesium:

https://groups.google.com/g/cesium-dev/c/MQVDWGU19T4

https://groups.google.com/g/cesium-dev/c/5N1P_qPmbPo/m/rbnHNKFoAQAJ

Here a video to demonstrate the problem:

cesium_blink-2021-06-22_12.05.01.mp4

@alexrobin What do you think about it?

@nickgaray Can you also add comments in the EllipseLayer class?
I added an example of ellipse in the showcase associated with the example Cesium-location-path

Thanks

Added comments to illustrate usage and denote meaning of properties for construction.
@nickgaray
Copy link
Collaborator Author

@mdhsl I have added comments to the EllipseLayer.js module to denote usage based on showcase example as well as describing properties for construction.

Thank you

@mdhsl mdhsl merged commit 9d5de77 into dev Jul 1, 2021
@mdhsl mdhsl deleted the ellipse-and-polyline-support branch July 24, 2021 16:02
@mdhsl mdhsl mentioned this pull request Jul 24, 2021
mdhsl added a commit that referenced this pull request Jul 24, 2021
*Fixed*
- #425 
- #446 
- #422 
- #378
- #445 
- #414 
- #379 
- #377 
- #360 
- #349 

*Updated*
- Upgrade ffmpeg.js to n4.4 + emscripten 2.0.26 24154f1
- TimeLine fires now a time-changed to alert the time has been changed

*Added*
- #441 
- #439 
- #444 
- #442 
- #426
- #389 
- #354 
- #376
- #390 
- #373 
- #362 
- Add documentation on howto publish NPM package 
- Update bundling components to automatically use DEV or LATEST depending on environment variable d8bb746
- Add some showcase examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants