Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust parameter values and config.json file #28

Closed
wants to merge 5 commits into from
Closed

Adjust parameter values and config.json file #28

wants to merge 5 commits into from

Conversation

MarcoDima
Copy link

  1. If request is sent with accepts_incomplete=false, but no request body is sent within it, then the status code should be 400 and not 422.

  2. An id like service_id="xxxx-xxxx" MIGHT be considered a valid id, as it can be globally unique and is not an empty string (as specified in the API).

  3. on DELETE/BINDING: When testing the deletion of an instance (or an instance_binding), an existing "instance_id" and "binding_id" should be given in the config.json file (in the path: "bindings") otherwise the test case would create a new guid and delete an instance (or instance_binding) with that guid, which not exists as it was not created.

@cfdreddbot
Copy link

Hey MarcoDima!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@kirederik
Copy link
Contributor

I think you accidentally committed the Mac OS ".DS_Store" files.

@leonwanghui
Copy link
Collaborator

Hi, how is it going about this patch?

@zhongyi-zhang
Copy link
Collaborator

@MarcoDima apologize for that we've redesigned the config file via #50. Therefore the PR is not compatible now :(. I am happy to review it if you'd like to create a new PR adjusting the current test framework. Your contributions are always appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants