Add Dockerfile for building test environment #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
|
Hey leonwanghui! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
n3wscott
reviewed
Jul 31, 2018
leonwanghui
requested review from
duglin,
mattmcneeney,
norshtein and
zhongyi-zhang
|
The PR mostly LGTM. One thing is, better to create a doc and add the description about how to use the docker image to the doc. |
| @@ -1,3 +1,5 @@ | |||
| VERSION_NUMBER := 2.13 | |||
There was a problem hiding this comment.
Do we need ifeq ($(VERSION_NUMBER),) here to allow manually setting version?
There was a problem hiding this comment.
I think for now it can be set to 2.13 statically.
|
I think the CI should be updated, too. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: leonwanghui wanghui71leon@gmail.com
Introduction
This patch mainly focuses on solving the issue #31
How to build mock-broker and test-job docker image
These commands below present how to building test environment:
After this finished, you will find two docker images created:
root@vultr:~/workspace/osb-checker# docker images REPOSITORY TAG IMAGE ID CREATED SIZE osb-checker/test-job 2.13 bd833779fd29 6 seconds ago 676MB osb-checker/mock-broker 2.13 deb24670b84c 10 seconds ago 672MBHow to run these two docker images