Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate parameters schema in Provision/Update/Bind request body #63

Merged
merged 3 commits into from
Nov 20, 2018
Merged

Validate parameters schema in Provision/Update/Bind request body #63

merged 3 commits into from
Nov 20, 2018

Conversation

leonwanghui
Copy link
Collaborator

Sloves #44

@leonwanghui leonwanghui self-assigned this Nov 19, 2018
@cfdreddbot
Copy link

✅ Hey leonwanghui! The commit authors and yourself have already signed the CLA.

zhongyi-zhang
zhongyi-zhang approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@zhongyi-zhang zhongyi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

2.13/tests/test/test.js Outdated Show resolved Hide resolved
norshtein
norshtein reviewed Nov 20, 2018
View reviewed changes
2.13/tests/test/test.js Outdated Show resolved Hide resolved
norshtein
norshtein requested changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@norshtein norshtein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

norshtein
norshtein reviewed Nov 20, 2018
View reviewed changes
2.13/tests/test/test.js Outdated Show resolved Hide resolved
norshtein
norshtein approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@norshtein norshtein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhongyi-zhang
zhongyi-zhang approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@zhongyi-zhang zhongyi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leonwanghui leonwanghui merged commit 5c158ca into openservicebrokerapi:master Nov 20, 2018
@leonwanghui leonwanghui deleted the json-validate branch November 20, 2018 06:13
@leonwanghui leonwanghui mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norshtein norshtein norshtein approved these changes

@zhongyi-zhang zhongyi-zhang zhongyi-zhang approved these changes

Assignees

@leonwanghui leonwanghui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leonwanghui @cfdreddbot @norshtein @zhongyi-zhang