Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

bump version of go to 1.19 #4972

Merged
merged 4 commits into from Aug 9, 2022

Conversation

steeling
Copy link
Contributor

@steeling steeling commented Aug 8, 2022

Resolves #4966

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #4972 (cea67b2) into main (273d5cd) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4972      +/-   ##
==========================================
- Coverage   68.35%   68.33%   -0.02%     
==========================================
  Files         220      220              
  Lines       15998    15998              
==========================================
- Hits        10935    10932       -3     
- Misses       5011     5014       +3     
  Partials       52       52              
Flag Coverage Δ
unittests 68.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/trafficpolicy/trafficpolicy.go 96.15% <ø> (ø)
pkg/messaging/workqueue.go 89.28% <0.00%> (-10.72%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@keithmattix
Copy link
Contributor

@steeling Can you please link the associated issue?

Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One, non-blocking comment

pkg/trafficpolicy/trafficpolicy.go Outdated Show resolved Hide resolved
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
@steeling steeling merged commit df502a7 into openservicemesh:main Aug 9, 2022
@steeling steeling deleted the feature/bump-version branch August 9, 2022 17:36
nshankar13 pushed a commit to nshankar13/osm that referenced this pull request Aug 31, 2022
Fix ingress backend broken SAN (openservicemesh#4914)

Fix ingress backend SAN's, which were getting the trust domain appended to the provided SAN.
This adds an e2e test to catch that going forward.
This also switches the internal builders to use the principal (trust domain appended) vs the identity (no trust domain)

Signed-off-by: nshankar13 <nshankar@microsoft.com>

[backport] cherry-pick 961c865 to release-v1.2

fix golints G114 and package-comments (openservicemesh#5037)

golints addressed:
1. G114: Use of net/http serve function that has no support for setting timeouts
2. package-comments
3. removes pkg mesh and moves isValidUUID() to pkg/cli/proxy_get.go

Signed-off-by: Shalier Xia <shalierxia@microsoft.com>

[backport] cherry-pick df502a7 to release-v1.2

bump version of go to 1.19 (openservicemesh#4972)

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix pushed a commit to keithmattix/osm that referenced this pull request Dec 12, 2022
bump version of go to 1.19

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix pushed a commit to keithmattix/osm that referenced this pull request Dec 12, 2022
bump version of go to 1.19

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix pushed a commit to keithmattix/osm that referenced this pull request Dec 12, 2022
bump version of go to 1.19

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix pushed a commit to keithmattix/osm that referenced this pull request Dec 12, 2022
bump version of go to 1.19

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix pushed a commit to keithmattix/osm that referenced this pull request Dec 13, 2022
bump version of go to 1.19

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix pushed a commit to keithmattix/osm that referenced this pull request Dec 13, 2022
bump version of go to 1.19

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix pushed a commit to keithmattix/osm that referenced this pull request Dec 13, 2022
bump version of go to 1.19

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix pushed a commit to keithmattix/osm that referenced this pull request Dec 13, 2022
bump version of go to 1.19

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.18 or higher
5 participants