Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(chart): update port for Zipkin Pod and Service #907

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jun 25, 2020

No description provided.

@nojnhuh nojnhuh requested a review from a team June 25, 2020 21:50
ksubrmnn
ksubrmnn previously approved these changes Jun 25, 2020
Copy link
Contributor

@ksubrmnn ksubrmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, can you write some documentation somewhere for the zipkin stuff when you get a chance?

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 25, 2020

As an aside, can you write some documentation somewhere for the zipkin stuff when you get a chance?

@draychev - Were you planning for some docs at some point? I can certainly help if needed.

shashankram
shashankram previously approved these changes Jun 25, 2020
snehachhabria
snehachhabria previously approved these changes Jun 25, 2020
Copy link
Contributor

@draychev draychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for fixing this -- I found this in my demo branch and meant to open a PR but you beat me to it!

@nojnhuh nojnhuh merged commit 715a852 into master Jun 26, 2020
@draychev
Copy link
Contributor

As an aside, can you write some documentation somewhere for the zipkin stuff when you get a chance?

@draychev - Were you planning for some docs at some point? I can certainly help if needed.

Yes - I'll add 2 issues 1) to flesh out Tracing 2) document

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants