Skip to content

Commit

Permalink
fix(DefaultColorMusic): Fix rehearsal marks ignoring defaultColorMusic (
Browse files Browse the repository at this point in the history
#1218) (svgcontext.rect ignoring stroke)
  • Loading branch information
sschmidTU committed Sep 19, 2022
1 parent c685b48 commit 2702667
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/VexFlowPatch/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ Add manual flag rendering variable so we can choose not to render flags if notes

svgcontext.js (custom addition, probably not necessary for vexflow 4):
able to add extra attributes (like svg node id) to a stroke (e.g. stem)
fix rect() always using black color, ignoring attributes.stroke (ctx strokeStlye) -> fix defaultColorMusic ignored

tabnote.js (merged Vexflow 3.x):
Add a context group for each tabnote, so that it can be found in the SVG DOM ("vf-tabnote")
Expand Down
2 changes: 1 addition & 1 deletion src/VexFlowPatch/src/svgcontext.js
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ export class SVGContext {
attributes = {
fill: 'none',
'stroke-width': this.lineWidth,
stroke: 'black',
stroke: this.attributes.stroke, // VexFlowPatch: fix hardcoded 'black' instead of attributes.stroke (ctx strokeStyle)
};
}

Expand Down

0 comments on commit 2702667

Please sign in to comment.