Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to get bpm? #557

Closed
JanvyHung opened this issue Aug 8, 2019 · 6 comments
Closed

How to get bpm? #557

JanvyHung opened this issue Aug 8, 2019 · 6 comments

Comments

@JanvyHung
Copy link

If bpm is displayed in the score, how to get it in the program？Also, is it possible to get a document for all available elements of OSMD?
@praisethemoon
Copy link
Collaborator

Hello, this is currently a feature that I am working on, basically, the BPM (aka tempo) is indeed rendered, and you can get its textual value. However, the code that extract the true BPM value is commented, IDK. I am currently working on implementing this, so stay tuned for my PR once I get it done. I will because I need it as well ;)

@praisethemoon
Copy link
Collaborator

Guess what, I think I just found out how :D @sschmidTU , I am thinking of creating a new attribute in SourceMeasure called tempoInBPM, do you have any better ideas? If there is a present BPM value, the current measure will be assigned that one, if not, it will inherit its previous measure's BPM.

@sschmidTU
Copy link
Contributor

sounds good! it's not graphical but measure data, so SourceMeasure seems like the right place.
I mean, in theory the tempo could change in the middle of the measure, and you could have a tempo per StaffEntry or something... but maybe not something to worry about right now.

@praisethemoon
Copy link
Collaborator

It is done, PR in few mins

@JanvyHung
Copy link
Author

JanvyHung commented Aug 21, 2019 via email

@praisethemoon
Copy link
Collaborator

@JanvyHung Hello, please refer to this comment: #558 (comment)

sschmidTU pushed a commit that referenced this issue Jan 15, 2020
@praisethemoon @sschmidTU
fix(Cursor): UI Performance Fix of Follow Cursor feature (#639)
8ec7b2f 
* Saving measures' BPM and fix #557

* Slight improvements, to handle cases where no BPM is mentioned.

* Fixed tiny confusion between `userStartTempoInBPM` and `userStartTempoInBPM`

* Added support for tempo that appears `metronome`

* Improved smoothness of cursor following mechanism.
sschmidTU added a commit that referenced this issue Jan 15, 2020
@sschmidTU @praisethemoon
Fix merge of PR #639 (#652)
4bd4184 
* Saving measures' BPM and fix #557

* Slight improvements, to handle cases where no BPM is mentioned.

* Fixed tiny confusion between `userStartTempoInBPM` and `userStartTempoInBPM`

* Added support for tempo that appears `metronome`

* Improved smoothness of cursor following mechanism.

Co-authored-by: Soulaymen Chouri <doit@praisethemoon.org>
sschmidTU added a commit that referenced this issue Jan 15, 2020
@sschmidTU @praisethemoon
Merge fix/ui follow cursor performance (#653)
9ebf10a 
* Saving measures' BPM and fix #557

* Slight improvements, to handle cases where no BPM is mentioned.

* Fixed tiny confusion between `userStartTempoInBPM` and `userStartTempoInBPM`

* Added support for tempo that appears `metronome`

* Improved smoothness of cursor following mechanism.

Co-authored-by: Soulaymen Chouri <doit@praisethemoon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@praisethemoon @sschmidTU @JanvyHung