Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SVGelement property to GraphicalLine #1542

Merged
merged 1 commit into from May 13, 2024
Merged

Added SVGelement property to GraphicalLine #1542

merged 1 commit into from May 13, 2024

Conversation

fablau
Copy link
Sponsor Contributor

@fablau fablau commented May 2, 2024

Added SVGelement property to GraphicalLine to be consistent with grap…hicalSlurs

@sschmidTU
Copy link
Contributor

Thanks, LGTM, merging.
I'll also add setting the SVGElement to the usage in drawGlissando(), which seems to be the only other applicable usage (there's also repeated usage in drawSampledLine(), but none of those GraphicalLines are saved).

@sschmidTU sschmidTU self-assigned this May 13, 2024
@sschmidTU sschmidTU merged commit 8a890bf into opensheetmusicdisplay:develop May 13, 2024
1 check passed
@sschmidTU
Copy link
Contributor

Also renamed the property to SVGElement (capital E) to be consistent.

sschmidTU pushed a commit that referenced this pull request May 13, 2024
feat(SVG): Save SVGElement for glissando line in drawLine usage (PR #…
8495b7e 
…1542), rename to SVGElement (capital E)

same idea as in PR #1542, last place where we can save the drawn line in usages of drawLine()
@fablau
Copy link
Sponsor Contributor Author

fablau commented May 14, 2024

Thank you Simon... and good catch about the missed capital E!

@fablau fablau deleted the GraphicalLine_SVGelement branch May 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sschmidTU sschmidTU

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fablau @sschmidTU