Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw colored Background Layer #318

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Draw colored Background Layer #318

wants to merge 16 commits into from

Commits on Jul 26, 2018

  1. fix(demo): extend sample name box length to not cut off sample titles

    @sschmidTU
    sschmidTU committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    e573414 View commit details
    Browse the repository at this point in the history

  2. fix(demo): sample names: last name first, then first names

    @sschmidTU
    sschmidTU committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    8fc4a39 View commit details
    Browse the repository at this point in the history

  3. fix(demo): sample list: prevent comma cut-off, align height with back… 

    …end selector
    @sschmidTU
    sschmidTU committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    e2c37c6 View commit details
    Browse the repository at this point in the history

  4. fix(demo): fix css desired sample width

    @sschmidTU
    sschmidTU committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    65d1d30 View commit details
    Browse the repository at this point in the history

  5. fix(demo): Bach "C Dur" -> "C-Dur"

    @sschmidTU
    sschmidTU committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    c62fb02 View commit details
    Browse the repository at this point in the history

  6. fix(in-measure clef): add as NoteSubGroup instead of ClefNote directl… 

    …y. placement still bugged

part of #307
    @sschmidTU
    sschmidTU committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    41ee64f View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2018

  1. in-measure clef: simplified adding modifier

    @sschmidTU
    sschmidTU committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    27a17ed View commit details
    Browse the repository at this point in the history

  2. fix indentation

    @sschmidTU
    sschmidTU committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    deca591 View commit details
    Browse the repository at this point in the history

  3. add in-measure clefs to function test

    @sschmidTU
    sschmidTU committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    82a0a34 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. attempt to fix canvas image having a transparent background when savi… 

    …ng (should be white).

setting backgroundFillStyle doesn't solve the problem for some reason.
attempt at #312
    @sschmidTU
    sschmidTU committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    3ab11ba View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. experimental code for background color. works for SVG, not for Canvas. 

    probably bug in vexflow.
    @sschmidTU
    sschmidTU committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    73cdb2b View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2018

  1. fix(canvasBackground): draw white background rectangle

    @sschmidTU
    sschmidTU committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    b1d1dee View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix/transparentToWhiteBackground, refacto… 

    …r for nicer code
    @sschmidTU
    sschmidTU committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    76d0f93 View commit details
    Browse the repository at this point in the history

  3. add ability to set background color, also to transparent

    @sschmidTU
    sschmidTU committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    9b5e602 View commit details
    Browse the repository at this point in the history

  4. try to fix cursor not showing

    @sschmidTU
    sschmidTU committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    f2107c1 View commit details
    Browse the repository at this point in the history

  5. fix background color with cursor, but cursor is less transparent (on … 

    …z=0 layer)
    @sschmidTU
    sschmidTU committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    ada473e View commit details
    Browse the repository at this point in the history