Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16041: Splits the preview badges into one component per module #2426

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jkilzi
Copy link
Contributor

@jkilzi jkilzi commented Oct 25, 2023

https://issues.redhat.com/browse/MGMT-16041

Extracts the tech and dev preview components from PreviewBadge.tsx and declares them in their own modules

@jkilzi jkilzi requested a review from a team as a code owner October 25, 2023 12:44
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2023

@jkilzi: This pull request references MGMT-16041 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2023

@jkilzi: This pull request references MGMT-16041 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-16041

Extracts the tech and dev preview components from PreviewBadge.tsx and declares them in their own modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkilzi jkilzi added this to the v2.27 milestone Oct 25, 2023
ammont82
ammont82 previously approved these changes Oct 25, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2023
@jkilzi jkilzi requested a review from ammont82 October 25, 2023 14:55
@jkilzi jkilzi merged commit 1993545 into openshift-assisted:master Oct 26, 2023
7 checks passed
@jkilzi jkilzi deleted the tasks/MGMT-16041 branch October 26, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants