Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-15919: If day1 cluster is ARM cpu arch, then only ARM nodes can be added in Day2 - followup #2440

Merged
merged 2 commits into from
Dec 1, 2023
Merged

MGMT-15919: If day1 cluster is ARM cpu arch, then only ARM nodes can be added in Day2 - followup #2440

merged 2 commits into from
Dec 1, 2023

Conversation

ammont82
Copy link
Contributor

Related to https://issues.redhat.com/browse/MGMT-15919

If day1 cluster is ARM cpu arch, then only ARM nodes can be added in Day2:
image

Other options in dropdown are disabled:
image

@ammont82 ammont82 added the OCM label Nov 23, 2023
@ammont82 ammont82 requested a review from a team as a code owner November 23, 2023 06:40
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 23, 2023 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-15919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-15919

If day1 cluster is ARM cpu arch, then only ARM nodes can be added in Day2:
image

Other options in dropdown are disabled:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2023
@ammont82 ammont82 added this to the v2.29 milestone Nov 23, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 1, 2023

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit 7c1f83d into openshift-assisted:master Dec 1, 2023
7 checks passed
@ammont82 ammont82 deleted the MGMT-15919-followup branch December 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkilzi jkilzi jkilzi approved these changes

@jgyselov jgyselov jgyselov approved these changes

Assignees

@jkilzi jkilzi

@jgyselov jgyselov

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OCM size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v2.29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ammont82 @openshift-ci-robot @jkilzi @jgyselov