Bug 2056485: Add pagination to tables if there are more than 10 items #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawagner
force-pushed
the
add_pagination
branch
from
ac8e518
to
c6e6b87
Compare
rawagner
changed the title
rawagner
force-pushed
the
add_pagination
branch
from
c6e6b87
to
0139d83
Compare
mareklibra
previously approved these changes
Feb 28, 2022
|
Looks great! |
|
PR updated, the pagination is not added to the top right corner too, if the table has a toolbar
|
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
You have my blessing (: |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
jtomasek
approved these changes
Mar 4, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jtomasek, rawagner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nirfarkas this adds pagination for every AI table in ACM and OCM when we have more than 10 items to show