Skip to content

Commit

Permalink
Merge pull request openshift#43 from njhale/rm-manifest-status
Browse files Browse the repository at this point in the history
Drop status subresource from generated CRD manifests
  • Loading branch information
njhale committed Jun 9, 2020
2 parents 431198d + f851f80 commit 6468209
Show file tree
Hide file tree
Showing 60 changed files with 20 additions and 238,148 deletions.
13 changes: 8 additions & 5 deletions Makefile
Expand Up @@ -12,7 +12,7 @@ endif
REPO = github.com/operator-framework/api
BUILD_PATH = $(REPO)/cmd/operator-verify
PKGS = $(shell go list ./... | grep -v /vendor/)
YQ_INTERNAL := $(Q) go run $(MOD_FLAGS) ./vendor/github.com/mikefarah/yq/v2/
YQ := go run $(MOD_FLAGS) ./vendor/github.com/mikefarah/yq/v2/

.PHONY: help
help: ## Show this help screen
Expand Down Expand Up @@ -61,14 +61,17 @@ manifests: controller-gen ## Generate manifests e.g. CRD, RBAC etc
$(CONTROLLER_GEN) schemapatch:manifests=./crds output:dir=./crds paths=./pkg/operators/...

@# Add missing defaults in embedded core API schemas
$(YQ_INTERNAL) w --inplace ./crds/operators.coreos.com_clusterserviceversions.yaml spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.install.properties.spec.properties.deployments.items.properties.spec.properties.template.properties.spec.properties.containers.items.properties.ports.items.properties.protocol.default TCP
$(YQ_INTERNAL) w --inplace ./crds/operators.coreos.com_clusterserviceversions.yaml spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.install.properties.spec.properties.deployments.items.properties.spec.properties.template.properties.spec.properties.initContainers.items.properties.ports.items.properties.protocol.default TCP
$(Q)$(YQ) w --inplace ./crds/operators.coreos.com_clusterserviceversions.yaml spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.install.properties.spec.properties.deployments.items.properties.spec.properties.template.properties.spec.properties.containers.items.properties.ports.items.properties.protocol.default TCP
$(Q)$(YQ) w --inplace ./crds/operators.coreos.com_clusterserviceversions.yaml spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.install.properties.spec.properties.deployments.items.properties.spec.properties.template.properties.spec.properties.initContainers.items.properties.ports.items.properties.protocol.default TCP

@# Preserve fields for embedded metadata fields
$(YQ_INTERNAL) w --inplace ./crds/operators.coreos.com_clusterserviceversions.yaml spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.install.properties.spec.properties.deployments.items.properties.spec.properties.template.properties.metadata.x-kubernetes-preserve-unknown-fields true
$(Q)$(YQ) w --inplace ./crds/operators.coreos.com_clusterserviceversions.yaml spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.install.properties.spec.properties.deployments.items.properties.spec.properties.template.properties.metadata.x-kubernetes-preserve-unknown-fields true

@# Remove status subresource from the CRD manifests to ensure server-side apply works
$(Q)for f in ./crds/*.yaml ; do $(YQ) d --inplace $$f status; done

@# Update embedded CRD files.
@go generate ./crds/...
$(Q)go generate ./crds/...

# Static tests.
.PHONY: test test-unit
Expand Down
6 changes: 0 additions & 6 deletions crds/operators.coreos.com_catalogsources.yaml
Expand Up @@ -185,9 +185,3 @@ spec:
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
6 changes: 0 additions & 6 deletions crds/operators.coreos.com_clusterserviceversions.yaml
Expand Up @@ -8946,9 +8946,3 @@ spec:
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
6 changes: 0 additions & 6 deletions crds/operators.coreos.com_installplans.yaml
Expand Up @@ -297,9 +297,3 @@ spec:
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
6 changes: 0 additions & 6 deletions crds/operators.coreos.com_operatorgroups.yaml
Expand Up @@ -302,9 +302,3 @@ spec:
storage: false
subresources:
status: {}
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
6 changes: 0 additions & 6 deletions crds/operators.coreos.com_operators.yaml
Expand Up @@ -174,9 +174,3 @@ spec:
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
6 changes: 0 additions & 6 deletions crds/operators.coreos.com_subscriptions.yaml
Expand Up @@ -1831,9 +1831,3 @@ spec:
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
24 changes: 12 additions & 12 deletions crds/zz_defs.go

Large diffs are not rendered by default.

28 changes: 0 additions & 28 deletions vendor/github.com/golang-migrate/migrate/v4/LICENSE

This file was deleted.

118 changes: 0 additions & 118 deletions vendor/github.com/golang-migrate/migrate/v4/source/driver.go

This file was deleted.

This file was deleted.

127 changes: 0 additions & 127 deletions vendor/github.com/golang-migrate/migrate/v4/source/file/file.go

This file was deleted.

0 comments on commit 6468209

Please sign in to comment.