Restore old release process for older branches #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
suggested changes
Jun 6, 2017
| @@ -6,6 +6,17 @@ extensions: | |||
| title: "build an origin release" | |||
| repository: "origin" | |||
| script: |- | |||
| CURRENT_BRANCH=$(git rev-parse --abbrev-ref --symbolic-full-name HEAD) | |||
There was a problem hiding this comment.
Use $ORIGIN_TARGET_BRANCH
|
The build in https://ci.openshift.redhat.com/jenkins/view/All/job/test_pull_request_origin_kargakis/1/console was successful. @stevekuznetsov ok to merge and roll out? |
stevekuznetsov
suggested changes
Jun 6, 2017
| @@ -6,6 +6,17 @@ extensions: | |||
| title: "build an origin release" | |||
| repository: "origin" | |||
| script: |- | |||
| ORIGIN_TARGET_BRANCH=$(git rev-parse --abbrev-ref --symbolic-full-name HEAD) | |||
There was a problem hiding this comment.
Sorry, I meant that there is a variable already available to you -- $<REPO_NAME>_TARGET_BRANCH for whatever is being tested. No need to do this.
There was a problem hiding this comment.
ok, updated once more
|
Kicked https://ci.openshift.redhat.com/jenkins/view/All/job/test_pull_request_origin_kargakis/2/console - will merge and push to Jenkins once the build passes. |
stevekuznetsov
approved these changes
Jun 6, 2017
Signed-off-by: Michail Kargakis <mkargaki@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stevekuznetsov I think this is the best approach out of the three. Testing openshift/origin#14422 in https://ci.openshift.redhat.com/jenkins/view/All/job/test_pull_request_origin_kargakis/1/console