cri-o: force image from docker.io for now #624
Conversation
openshift-ci-robot
added
the
size/XS
|
@mrunalp this should fix the origin tests with cri-o |
|
👍 |
|
@giuseppe we also released yesterday cri-o v1 RC1, could you also update your Docker image to use that? (and maybe also the RH registry image) |
|
/cc @stevekuznetsov |
|
You also need to update the generated xml that will be pushed in Jenkins ./sjb/generate.sh |
openshift/openshift-ansible#5310 was merged before the image for RHEL was ready. Until that it is done, force the image from docker.io. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
crio-force-docker-io
branch
from
99a1a57
to
5f61ec4
Compare
| @@ -58,6 +58,7 @@ extensions: | |||
| --inventory sjb/inventory/ \ | |||
| -e deployment_type=origin \ | |||
| -e openshift_use_crio=True \ | |||
| -e openshift_crio_systemcontainer_image_registry_override=docker.io/gscrivano \ | |||
There was a problem hiding this comment.
Should this also specify the name cri-o-centos|cri-o-fedora? This PR, afaict, is now pulling docker.io/gscrivano/cri-o:latest which doesn't exist. @giuseppe @ashcrow (ref: https://github.com/openshift/openshift-ansible/pull/5310/files#diff-15e7f96a54339bec77c2213d0bf9e49dR99)
There was a problem hiding this comment.
@ashcrow do we need to change this in openshift-ansible? I think it is reasonable to override the entire image not just the registry, what do you think if we drop the openshift_crio_systemcontainer_image_registry_override logic in favour of openshift_crio_systemcontainer_image_override and do the same for the docker system container?
There was a problem hiding this comment.
I've tagged docker.io/gscrivano/cri-o for now.
There was a problem hiding this comment.
I'll make the change but this can merge as it will work as is.
@giuseppe do you have access to push the update in Jenkins? Also, is there an issue somewhere to track when we can remove the override? |
|
@Kargakis no, I have no access to push the update I think. How can I check that? |
If this didn't come out clear, I was asking for something like #627
You need credentials for https://ci.openshift.redhat.com/jenkins/ See https://mojo.redhat.com/docs/DOC-1081313#jive_content_id_Jenkins for more information. In the meantime, I can push this in Jenkins. Is it ready to merge or do you need anything more? |
|
@Kargakis it should be fine now |
openshift/openshift-ansible#5310 was merged
before the image for RHEL was ready. Until that it is done, force the
image from docker.io.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com