error if multiple urls are defined

openshift-eng · Nov 23, 2022 · 475b997 · 475b997
1 parent 60b3da9
commit 475b997
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/doozerlib/rhcos.py b/doozerlib/rhcos.py
@@ -132,10 +132,14 @@ def rhcos_release_url(self) -> str:
         if self.custom:
             bucket += '-custom'
 
-        if self.runtime.group_config.urls.rhcos_release_base[bucket]:
-            return self.runtime.group_config.urls.rhcos_release_base[bucket]
-        elif self.runtime.group_config.urls.rhcos_release_base["multi"]:
-            return self.runtime.group_config.urls.rhcos_release_base["multi"]
+        multi_url = self.runtime.group_config.urls.rhcos_release_base["multi"]
+        bucket_url = self.runtime.group_config.urls.rhcos_release_base[bucket]
+        if multi_url:
+            if bucket_url:
+                raise ValueError(f"Multiple rhcos_release_base urls found in group config: `multi` and `{bucket}`")
+            return multi_url
+        if bucket_url:
+            return bucket_url
 
         bucket_suffix = brew_suffix_for_arch(self.brew_arch)
         if self.custom: