Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Commit

Permalink
plashet: don't fail on --include-previous for a pinned package
Browse files Browse the repository at this point in the history
Currently, plashet will fail if a specific package version is pinned but
we also have `--include-previous` option used for that package to
request a previous version of that.

This breaks sync-for-ci-ironic job after we pin 8.6 kernel-rt to stream
assembly. Let's change the behavior to emit a warning instead.
  • Loading branch information
vfreex committed Nov 23, 2022
1 parent 2df1a76 commit e5edce5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion doozerlib/cli/config_plashet.py
Expand Up @@ -628,7 +628,8 @@ def is_embargoed(an_nvre):
if package_name.startswith(tuple(include_previous_for)) or include_previous:
# The user has asked for non-latest entry for this package to be included in the plashet.
if package_name in pinned_nvres:
raise IOError(f'Unable to build plashet. Build {nvre} is required by the assembly config but also asked to include a previous version.')
logger.warning("Previous version of %s package will not be included because %s is required by the assembly config", package_name, nvre)
continue

# we can try to find this by looking at the packages full history in this tag. Listing is
# newest -> oldest tagging event for this tag/package combination.
Expand Down

0 comments on commit e5edce5

Please sign in to comment.