This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
get-nightlies: revamp for deeper comparison #622
Merged
thegreyd
merged 3 commits into
openshift-eng:master
from
sosiouxme:20220718-get-matching-nightlies
Jul 25, 2022
Merged
get-nightlies: revamp for deeper comparison #622
thegreyd
merged 3 commits into
openshift-eng:master
from
sosiouxme:20220718-get-matching-nightlies
Jul 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosiouxme
force-pushed
the
20220718-get-matching-nightlies
branch
from
July 19, 2022 14:43
6907538
to
a00725a
Compare
thegreyd
reviewed
Jul 19, 2022
thegreyd
reviewed
Jul 19, 2022
thegreyd
reviewed
Jul 19, 2022
thegreyd
reviewed
Jul 19, 2022
thegreyd
reviewed
Jul 20, 2022
thegreyd
reviewed
Jul 21, 2022
thegreyd
reviewed
Jul 21, 2022
thegreyd
reviewed
Jul 21, 2022
Comparing timestamps on nightlies can only go so far. For a more reliable indicator that all the nightlies selected are "the same thing" get-nightlies now compares contents quite deeply. This should be reliable enough to feed into gen-assembly or to use in jobs checking that nightlies are available for upcoming releases. It also allows specifying a nightly you'd like in the set and other improvements.
sosiouxme
force-pushed
the
20220718-get-matching-nightlies
branch
from
July 22, 2022 13:03
5eb5f20
to
258a7ee
Compare
sosiouxme
force-pushed
the
20220718-get-matching-nightlies
branch
from
July 22, 2022 13:10
258a7ee
to
3b8cd1a
Compare
Build #8
|
@thegreyd I refactored toward a Nightly class, I think it's cleaner. Also ended up removing the initial RHCOS comparison by labels which wasn't adding much value. However further optimization to limit generation of candidate sets seemed like it would add complexity for not much benefit; it would only reduce the number of release images pulled, but those already happen quickly in parallel. Deeper equivalence checking is already limited. So, no change there. |
/lgtm |
Let's ship it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing timestamps on nightlies can only go so far.
For a more reliable indicator that all the nightlies selected are "the same thing" get-nightlies now compares contents quite deeply.
This should be reliable enough to feed into gen-assembly or to use in jobs checking that nightlies are available for upcoming releases.
It also allows specifying a nightly you'd like in the set and other improvements.