This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Comment on pr - restrict to stream #765
Merged
thegreyd
merged 2 commits into
openshift-eng:master
from
thegreyd:comment_on_pr_restrict_to_stream
Apr 28, 2023
Merged
Comment on pr - restrict to stream #765
thegreyd
merged 2 commits into
openshift-eng:master
from
thegreyd:comment_on_pr_restrict_to_stream
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegreyd
commented
Apr 28, 2023
@@ -95,8 +95,10 @@ def setUp(self): | |||
Define and provide mock logging for test/response | |||
""" | |||
self.stream = io.StringIO() | |||
logging.basicConfig(level=logging.DEBUG, stream=self.stream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 tests were failing on my local because something was breaking here
thegreyd
changed the title
Comment on pr restrict to stream
Comment on pr - restrict to stream
Apr 28, 2023
Build #1
|
locriandev
approved these changes
Apr 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.