[ART-7273] add modifications to support rhel-8-golang-1.17 #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Ximinhan
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
joepvd
previously requested changes
Aug 10, 2023
|
|
||
| # FOD wrapper modification | ||
| COPY go_wrapper.sh /tmp/go_wrapper.sh | ||
| RUN /bin/bash -c 'GO_BIN_PATH=`which go`; mv $GO_BIN_PATH $GO_BIN_PATH.real; mv /tmp/go_wrapper.sh $GO_BIN_PATH; chmod +x $GO_BIN_PATH' |
There was a problem hiding this comment.
RUN already is a shell. Not sure wrapping with bash -c '...' is necessary.
images/openshift-golang-builder.yml
Outdated
| @@ -7,6 +7,11 @@ content: | |||
| branch: | |||
| target: rhel-8-golang-1.17 | |||
| url: git@github.com:openshift/ocp-build-data.git | |||
| modifications: | |||
| - action: add | |||
| source: target_go_wrapper.sh | |||
There was a problem hiding this comment.
doozer pr talks about doozerpath?
Ximinhan
force-pushed
the
rhel-8-golang-1.17
branch
from
2d8335f
to
03bd3bd
Compare
|
/hold cancel |
Ximinhan
force-pushed
the
rhel-8-golang-1.17
branch
from
03bd3bd
to
68b37a3
Compare
joepvd
reviewed
Sep 8, 2023
images/openshift-golang-builder.yml
Outdated
| @@ -25,6 +30,7 @@ name: openshift/golang-builder | |||
| owners: | |||
| - aos-team-art@redhat.com | |||
|
|
|||
| # Don't add floating tag to FoD builder for now, until we confident CPASS can use it | |||
Ximinhan
force-pushed
the
rhel-8-golang-1.17
branch
from
68b37a3
to
5b6f0ec
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ximinhan
merged commit 9c5a8f2
into
openshift-eng:rhel-8-golang-1.17
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add go wrapper during golang build process, the wrapper script will get from openshift-eng/doozer#811
rhel-8-golang-1.17 can built with FoD wrapper and don't update new builder to floating tag for now